Skip to content

refactor(debit_routing): make the savings as the absolute value #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(debit_routing): make the savings as the absolute value #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions src/decider/network_decider/helpers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ impl types::CoBadgedCardRequest {
.await?;

logger::debug!("Total fees per debit network: {:?}", network_costs);
network_costs.sort_by(|(_, fee1), (_, fee2)| fee1.total_cmp(fee2));

let network_saving_infos = Self::calculate_network_saving_infos(network_costs, amount)?;
let network_saving_infos =
Self::calculate_network_saving_infos_with_savings_as_absolute_value(&mut network_costs);

Some(types::DebitRoutingOutput {
co_badged_card_networks_info: network_saving_infos,
Expand Down Expand Up @@ -136,6 +136,30 @@ impl types::CoBadgedCardRequest {
.flatten()
}

fn calculate_network_saving_infos_with_savings_as_absolute_value(
network_costs: &mut Vec<(gateway_decider_types::NETWORK, f64)>,
) -> Vec<types::NetworkSavingInfo> {
// Sort the network costs by fee
network_costs.sort_by(|(_, fee1), (_, fee2)| fee1.total_cmp(fee2));

// Get the most expensive fee
let most_expensive_fee = network_costs.last().map(|(_, fee)| *fee).unwrap_or(0.0);
Comment on lines +142 to +146
Copy link

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using unwrap_or(0.0) when network_costs is empty will result in all savings being calculated as negative values (0.0 - fee). This could lead to incorrect savings calculations. Consider returning early or handling the empty case explicitly.

Suggested change
// Sort the network costs by fee
network_costs.sort_by(|(_, fee1), (_, fee2)| fee1.total_cmp(fee2));
// Get the most expensive fee
let most_expensive_fee = network_costs.last().map(|(_, fee)| *fee).unwrap_or(0.0);
// Return early if network_costs is empty
if network_costs.is_empty() {
return Vec::new();
}
// Sort the network costs by fee
network_costs.sort_by(|(_, fee1), (_, fee2)| fee1.total_cmp(fee2));
// Get the most expensive fee
let most_expensive_fee = network_costs.last().map(|(_, fee)| *fee).unwrap();

Copilot uses AI. Check for mistakes.

// Create the network saving info
let mut network_saving_infos = Vec::new();
for (network, fee) in network_costs {
network_saving_infos.push(types::NetworkSavingInfo {
network: network.clone(),
saving_percentage: most_expensive_fee - *fee,
});
}

logger::debug!("Network saving infos: {:?}", network_saving_infos);

network_saving_infos
}

#[allow(dead_code)]
fn calculate_savings<F>(
costs: Vec<(gateway_decider_types::NETWORK, f64)>,
calc_savings_percentage: F,
Expand All @@ -152,7 +176,8 @@ impl types::CoBadgedCardRequest {
.collect()
}

fn calculate_network_saving_infos(
#[allow(dead_code)]
fn calculate_network_saving_infos_with_savings_as_percentage(
sorted_network_costs: Vec<(gateway_decider_types::NETWORK, f64)>,
transaction_amount: f64,
) -> Option<Vec<types::NetworkSavingInfo>> {
Expand Down
Loading