Skip to content

Conversation

@maxcao13
Copy link
Contributor

Related to: #18

Went through this documentation: https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md#cloudbuildyaml

Some things to note:

  • We are okay with this being the staging image name? karpenter-clusterapi-controller:whatever-git-tag
  • I tested this cloudbuild.yaml file with my own personal gcloud account and project, and pushing to my own repository (https://quay.io/repository/macao/karpenter-clusterapi-controller)
    • I can't test this with the actual staging repo (and I probably shouldn't have access to do that anyways)

I will need to create a prow job in the next steps of that documentation after this is merged.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2025
@maxcao13
Copy link
Contributor Author

/cc @elmiko @ttsuuubasa

@k8s-ci-robot k8s-ci-robot requested a review from elmiko October 29, 2025 00:22
@k8s-ci-robot
Copy link
Contributor

@maxcao13: GitHub didn't allow me to request PR reviews from the following users: ttsuuubasa.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @elmiko @ttsuuubasa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@elmiko
Copy link
Collaborator

elmiko commented Oct 29, 2025

We are okay with this being the staging image name? karpenter-clusterapi-controller:whatever-git-tag

i don't have an objection to this.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2025
@ttsuuubasa
Copy link
Contributor

Thank you for creating this. I think it's good too—looks good to me.

@elmiko
Copy link
Collaborator

elmiko commented Oct 29, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, maxcao13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5356bd8 into kubernetes-sigs:main Oct 29, 2025
4 checks passed
@maxcao13 maxcao13 deleted the cloudbuild branch October 29, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants