Fix castling premove to respect rookCastle preference #18587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update king mobility function in premove validation to only allow the user's preferred castling method. This matches the fix in chessground and ensures premoves work correctly with both castling preferences. Depends on: lichess-org/chessground#[PR-number-from-step-1]
Contributor
|
@rhowel33 Thanks - funny coincidence, I was just about to start work on this haha. For chessground we won't need to match, since we've been moving the logic there over to lila. After #365, cg's premove functionality will be back to its minimalistic state from June-July. Since we're trying to trim down |
Author
|
Gotcha, I will take a look at #18565 and see what changes need to be made. I'll also close the chess ground pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update king mobility function in premove validation to only allow the user's preferred castling method. This matches the fix in chessground and ensures premoves work correctly with both castling preferences.
For issue: #18586
Depends on: lichess-org/chessground#366