Skip to content

Fix castling premove to respect rookCastle preference #18587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −4
Open

Fix castling premove to respect rookCastle preference #18587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ui/round/src/premove.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,13 @@ const king: cg.Mobility = (ctx: cg.MobilityContext) =>
(ctx.canCastle &&
ctx.orig.pos[1] === ctx.dest.pos[1] &&
ctx.orig.pos[1] === (ctx.color === 'white' ? 0 : 7) &&
((ctx.orig.pos[0] === 4 &&
((ctx.dest.pos[0] === 2 && ctx.rookFilesFriendlies.includes(0)) ||
(ctx.dest.pos[0] === 6 && ctx.rookFilesFriendlies.includes(7)))) ||
ctx.rookFilesFriendlies.includes(ctx.dest.pos[0])) &&
(ctx.rookCastle
? // Rook castling: king moves onto rook
ctx.rookFilesFriendlies.includes(ctx.dest.pos[0])
: // Standard castling: king moves two squares
ctx.orig.pos[0] === 4 &&
((ctx.dest.pos[0] === 2 && ctx.rookFilesFriendlies.includes(0)) ||
(ctx.dest.pos[0] === 6 && ctx.rookFilesFriendlies.includes(7)))) &&
(ctx.unrestrictedPremoves ||
/* The following checks if no non-rook friendly piece is in the way between the king and its castling destination.
Note that for the Chess960 edge case of Kb1 "long castling", the check passes even if there is a piece in the way
Expand Down
Loading