[M68k] add test showing callseq begin failure for doubles, and fix mem chain generation #170049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m chain generation
knickish
force-pushed
the
m68k_call_seq_start_fix
branch
from
c513a96 to
5b87c12
Compare
Contributor
Author
|
@mshockwave can you sanity check this if you have time before it gets sent to SelectionDAG review? It's really dumb, but apparently fixes the callseq start assertion. seems to pass all the x86 and m68k tests |
mshockwave
reviewed
Dec 4, 2025
| unsigned MaxNest = 0; | ||
| SDNode *N = FindCallSeqStart(Node, NestLevel, MaxNest, TII); | ||
| assert(N && "Must find call sequence start"); | ||
| if (!N) |
Member
There was a problem hiding this comment.
if we bail out upon failing to find callseq_start, then we might not be able to prevent other instructions from getting between callseq_start & call instruction & callseq_end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove assertions on finding callseq start and don't use multiple chains when lowering calls