Use codicons from npm package #278593
Draft
Use codicons from npm package #278593
+32
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates from bundled codicon font files to using the @vscode/codicons npm package (version 0.0.42). The change centralizes the codicon font source and improves maintainability by leveraging the published npm package.
Key Changes
- Added
@vscode/codiconsnpm package as a dependency - Modified
getIconsStyleSheetto accept anIEnvironmentServiceparameter to determine the correct module path - Removed the static
@font-facedeclaration fromcodicon.cssand replaced it with dynamic CSS generation
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added @vscode/codicons version 0.0.42 as a dependency |
| package-lock.json | Added lockfile entry for @vscode/codicons package |
| src/vs/platform/theme/browser/iconsStyleSheet.ts | Added getModuleLocation helper and updated getIconsStyleSheet to accept environmentService, dynamically generates @font-face rule |
| src/vs/workbench/services/themes/browser/workbenchThemeService.ts | Updated call to getIconsStyleSheet to pass environmentService |
| src/vs/editor/standalone/browser/standaloneThemeService.ts | Updated call to getIconsStyleSheet to pass _environment |
| src/vs/workbench/contrib/issue/browser/baseIssueReporterService.ts | Added environmentService parameter and updated call to getIconsStyleSheet |
| src/vs/workbench/contrib/issue/electron-browser/issueReporterService.ts | Added environmentService parameter and passed to parent constructor |
| src/vs/workbench/contrib/issue/browser/issueReporterService.ts | Added environmentService parameter and passed to parent constructor |
| src/vs/base/browser/ui/codicons/codicon/codicon.css | Removed static @font-face declaration (now generated dynamically) |
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Contributor
…eme service (#278734) * Initial plan * Initialize _environment with isBuilt: false for standalone editor Co-authored-by: alexr00 <[email protected]> * Simplify _environment initialization to use object literal Co-authored-by: alexr00 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.