Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 21, 2025

The _environment object in StandaloneThemeService was created with Object.create(null), lacking the isBuilt property required by getIconsStyleSheet to determine the correct codicons module path.

Change:

  • Initialize _environment with { isBuilt: false } as IEnvironmentService instead of Object.create(null)

Context:
getIconsStyleSheet uses environmentService.isBuilt to select between ASAR unpacked and regular node_modules paths:

export function getModuleLocation(environmentService: IEnvironmentService): AppResourcePath {
	return `${(canASAR && environmentService.isBuilt) ? nodeModulesAsarUnpackedPath : nodeModulesPath}/@vscode/codicons/dist/codicon.ttf`;
}

For standalone editor scenarios (development/browser environments), isBuilt: false ensures the correct non-ASAR path is used.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Address feedback on using codicons from npm package Initialize environment service with isBuilt property in standalone theme service Nov 21, 2025
Copilot AI requested a review from alexr00 November 21, 2025 10:09
Copilot finished work on behalf of alexr00 November 21, 2025 10:09
@alexr00 alexr00 marked this pull request as ready for review November 21, 2025 10:21
@alexr00 alexr00 merged commit 22a2a38 into alexr00/definite-elephant Nov 21, 2025
8 of 9 checks passed
@alexr00 alexr00 deleted the copilot/sub-pr-278593 branch November 21, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants