Initialize environment service with isBuilt property in standalone theme service #278734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_environmentobject inStandaloneThemeServicewas created withObject.create(null), lacking theisBuiltproperty required bygetIconsStyleSheetto determine the correct codicons module path.Change:
_environmentwith{ isBuilt: false } as IEnvironmentServiceinstead ofObject.create(null)Context:
getIconsStyleSheetusesenvironmentService.isBuiltto select between ASAR unpacked and regular node_modules paths:For standalone editor scenarios (development/browser environments),
isBuilt: falseensures the correct non-ASAR path is used.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.