Skip to content

Conversation

@zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Nov 26, 2025

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 26, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 26, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 37.77778% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.98%. Comparing base (7d19c40) to head (a9a7bca).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/datanode/index/task_stats.go 0.00% 10 Missing ⚠️
internal/querynodev2/segments/segment_loader.go 50.00% 8 Missing and 1 partial ⚠️
internal/util/indexcgowrapper/index.go 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #45875       +/-   ##
===========================================
- Coverage   82.72%   75.98%    -6.74%     
===========================================
  Files         524     1888     +1364     
  Lines       82346   294979   +212633     
===========================================
+ Hits        68118   224143   +156025     
- Misses      14228    63405    +49177     
- Partials        0     7431     +7431     
Components Coverage Δ
Client 78.17% <ø> (∅)
Core 82.72% <ø> (ø)
Go 74.03% <42.85%> (∅)
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 97.64% <100.00%> (ø)
internal/querynodev2/segments/segment_loader.go 57.97% <50.00%> (ø)
internal/util/indexcgowrapper/index.go 55.90% <0.00%> (ø)
internal/datanode/index/task_stats.go 52.69% <0.00%> (ø)

... and 1360 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify
Copy link
Contributor

mergify bot commented Nov 27, 2025

@zhagnlu cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Nov 27, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 27, 2025
@zhagnlu zhagnlu force-pushed the estimate_jsonstats branch from c11576b to a9a7bca Compare December 1, 2025 03:51
@sparknack
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhagnlu, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3901f11 into milvus-io:master Dec 1, 2025
17 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants