Support Over Rollout #376
Merged
Support Over Rollout #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary of ChangesHello @pan-x-c, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements an experimental 'Over Rollout' feature designed to optimize task execution by submitting more tasks than are strictly necessary, and then waiting for a subset of them to complete. This involves a substantial overhaul of the task scheduling and execution logic, including how tasks are managed, metrics are collected and aggregated, and results are processed. The changes are supported by new configuration options and comprehensive unit tests to ensure the feature's correctness and compatibility. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an experimental "Over Rollout" feature, which is a valuable optimization for handling straggler tasks during exploration. The implementation includes a significant and well-executed refactoring of the scheduler and workflow runner to manage task splitting and result aggregation. The approach to calculating and propagating metrics has also been enhanced. My review focuses on identifying a bug in the new tests, suggesting simplifications to reduce code complexity and duplication, and correcting minor inconsistencies to improve overall code quality.
Collaborator
Author
|
/unittest-all |
Collaborator
Author
|
/unittest-module-explorer |
Collaborator
Author
|
/unittest-module-explorer |
Collaborator
Author
|
/unittest-module-trainer |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-module-trainer |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-module-explorer |
Collaborator
Author
|
/unittest-module-trainer |
Collaborator
Author
|
/unittest-diff |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
hiyuchang
reviewed
Nov 13, 2025
Collaborator
Author
|
/unittest-all |
Summary
Failed Tests
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-module-trainer |
Summary
Failed Tests
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-module-trainer |
Summary
Failed Tests
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-module-trainer |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
chenyushuo
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
Experimental feature. The inferface may change in future versions.
This PR introduces "Over Rollout", which submitting
ntasks at each step, but only waiting for1 - over_rollout_rateof them to return.Checklist
Please check the following items before code is ready to be reviewed.