Make buffer reader registerable #395
Merged
+334
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary of ChangesHello @pan-x-c, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the extensibility and modularity of the buffer reading and task scheduling components. It introduces a registry-based system for buffer readers, allowing for dynamic instantiation, and refactors the task scheduler hierarchy to support more flexible scheduling strategies. These changes aim to simplify future additions and maintenance of different buffer and task management mechanisms. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the buffer reader creation to use a registry pattern, which is a great improvement for extensibility and code clarity. The introduction of TasksetSchedulerBase and SimpleTasksetScheduler also helps to simplify the logic for single-taskset scenarios.
However, I've found a couple of issues in the new SimpleTasksetScheduler implementation that need to be addressed: a critical bug in read_async that will cause a runtime error, and an issue in state_dict that prevents correct checkpointing and resuming. Please see my detailed comments below.
pan-x-c
changed the title
Collaborator
Author
|
/unittest-module-buffer |
Summary
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-all |
Summary
Failed Tests
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-all |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the buffer reader creation to use a registry pattern, which is a great improvement for extensibility. The code is cleaner and easier to maintain. I've added a few comments with suggestions to further improve the implementation, mainly around making stubbed methods more explicit, reducing code duplication, and simplifying class hierarchies. Overall, this is a solid contribution.
hiyuchang
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title says
Checklist
Please check the following items before code is ready to be reviewed.