Skip to content

Conversation

@ErichDonGubler
Copy link
Contributor

Regressed by #393 (CC @padenot as the author of that PR). Prompted by bug 1999127, comment 8 from @tomrittervg.

@tomrittervg tomrittervg self-requested a review November 17, 2025 20:50
@tomrittervg tomrittervg self-assigned this Nov 17, 2025
@tomrittervg tomrittervg removed their assignment Nov 17, 2025
@ErichDonGubler
Copy link
Contributor Author

ErichDonGubler commented Nov 17, 2025

@tomrittervg: Just pushed up another fix that I think is uncontroversial (CC @padenot).

@ErichDonGubler
Copy link
Contributor Author

NOTE: I have not fully tested this, because I'm unfamiliar with how to do so here. The change seemed simple enough, and I've run this locally to make sure the new hostname check snippet itself works:

def is_chromium(repo: str) -> bool:
    return any(
        hostname in repo
        for hostname in [
            "https://chromium.googlesource.com",
            "https://aomedia.googlesource.com",
        ]
    )
    
assert is_chromium("https://chromium.googlesource.com")
assert is_chromium("https://aomedia.googlesource.com")
assert not is_chromium("https://github.com")
assert not is_chromium("https://gitlab.com")

@tomrittervg tomrittervg merged commit 0609517 into mozilla-services:master Nov 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants