Skip to content

fix(scm): correctly check hostnames for repo URL generation #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
+7 −1
Merged

fix(scm): correctly check hostnames for repo URL generation #407

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dec012e
fix(scm): correctly check hostnames for repo URL generation
ErichDonGubler Nov 17, 2025
086d358
fix(scm): remove extra `https://` from `aomedia.googlesource.com` hos…
ErichDonGubler Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion components/scmprovider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@


def repo_and_commit_to_url(repo, commit):
if "https://chromium.googlesource.com" or 'https://https://aomedia.googlesource.com' in repo:
if any(
hostname in repo
for hostname in [
"https://chromium.googlesource.com",
"https://aomedia.googlesource.com",
]
):
return repo + "/+/" + commit

# gitlab wants https://domain.com/org/project/-/commit/sha
Expand Down