Skip to content

Conversation

@thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Nov 15, 2025

Changes

This switches the list nested in an aspnetcore note to - so that the doc can be linted.

Important

Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion in #189

@github-project-automation github-project-automation bot moved this from Untriaged to Blocked in Semantic Conventions Triage Nov 17, 2025
@trask
Copy link
Member

trask commented Nov 17, 2025

@thompson-tomo is this the only place * is used other than -? we don't really want to enforce at this time, and we also don't want a lot of PRs that only do these changes that don't have any clear benefit

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Nov 18, 2025

@lmolkova i can see why you would draw a bow to prettier however that is not the correct bow to draw. This PR is part of getting linting running on all the generated content which is currently not the case and different to adding a formatter. That is why it is linked to #3074 and without this change the entire signal definition needs a manual suppression as seen in #3074

@trask this in the only case needed to eliminate linting suppression from general docs (manually created excluding resource docs). If you want to see the benefit of having linting run on the docs, just look at #3073 which would've been caught by linting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants