-
Notifications
You must be signed in to change notification settings - Fork 3
Adds LegacyXmlMixin in the xml_utils and make HTML XBlock use the corresponding XML parsing methods
#111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- This commit contains original `XmlMixin` copied from edx-platform. Purpose of keeping the first commit with original code is to view the changes in the diff easily.
|
Thanks for the pull request, @ttqureshi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
3473d63 to
81d3567
Compare
- HTML XBlock extends from the `LegacyXmlMixin` - It will use the parsing functionality from this mixin.
81d3567 to
aba204c
Compare
kdmccormick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
For the other blocks, feel free to update them all in a single PR if that's easier for you.
farhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🌟
@kdmccormick thanks for the PR review. I'm currently working on the test case failures in the test PR on edx-platform. Once all checks are green we are good to merge this PR. |
339f3bd to
aa2cf24
Compare
|
@farhan |
xml_utilsand add support for pointer tag utilities in the HTML XBlock. public-engineering#435In this PR, I have:
LegacyXmlMixininxblocks_contrib/common/xml_utils.LegacyXmlMixin.