Skip to content

Conversation

@ttqureshi
Copy link
Member

@ttqureshi ttqureshi commented Nov 19, 2025

In this PR, I have:

  • added the LegacyXmlMixin in xblocks_contrib/common/xml_utils.
  • removed the XML parsing methods from HTML XBlock by extending it from LegacyXmlMixin.

- This commit contains original `XmlMixin` copied from edx-platform.
Purpose of keeping the first commit with original code is to view the changes in the diff easily.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 19, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @ttqureshi!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Nov 19, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Nov 19, 2025
@ttqureshi ttqureshi force-pushed the ttqureshi/xmlmixin branch 10 times, most recently from 3473d63 to 81d3567 Compare November 21, 2025 10:30
- HTML XBlock extends from the `LegacyXmlMixin`
- It will use the parsing functionality from this mixin.
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

For the other blocks, feel free to update them all in a single PR if that's easier for you.

Copy link
Contributor

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🌟

@ttqureshi
Copy link
Member Author

For the other blocks, feel free to update them all in a single PR if that's easier for you.

@kdmccormick thanks for the PR review. I'm currently working on the test case failures in the test PR on edx-platform. Once all checks are green we are good to merge this PR.

@ttqureshi
Copy link
Member Author

@farhan
PR is up for final pass.

@ttqureshi ttqureshi merged commit cd5cfe7 into main Nov 28, 2025
11 of 13 checks passed
@ttqureshi ttqureshi deleted the ttqureshi/xmlmixin branch November 28, 2025 13:17
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Create xml_utils and add support for pointer tag utilities in the HTML XBlock.

6 participants