refactor(vscode): split lsp releated code to linter.ts
#15789
Merged
+374
−329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-cleanup
Sysix
force-pushed
the
11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_
branch
from
10e27ce to
c922d13
Compare
Sysix
force-pushed
the
11-17-refactor_vscode_add_workspaceconfig_methods_for_different_lsp_tools
branch
from
bd99750 to
0d63181
Compare
Sysix
force-pushed
the
11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_
branch
from
c922d13 to
df6d604
Compare
Sysix
force-pushed
the
11-17-refactor_vscode_add_workspaceconfig_methods_for_different_lsp_tools
branch
from
0d63181 to
e70f0d3
Compare
Sysix
force-pushed
the
11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_
branch
from
df6d604 to
cc0ec55
Compare
graphite-app
bot
changed the base branch from
11-17-refactor_vscode_add_workspaceconfig_methods_for_different_lsp_tools
to
graphite-base/15789
graphite-app
bot
force-pushed
the
11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_
branch
from
cf172c8 to
56be34f
Compare
graphite-app
bot
force-pushed
the
graphite-base/15789
branch
from
e70f0d3 to
985d48f
Compare
graphite-app
bot
force-pushed
the
11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_
branch
from
56be34f to
f7ff45d
Compare
Sysix
force-pushed
the
11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_
branch
2 times, most recently
from
240f96d to
e919504
Compare
Copilot finished reviewing on behalf of
Sysix
November 18, 2025 15:28
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the VSCode extension by extracting LSP-related functionality from extension.ts into a new linter.ts module, improving code organization and separation of concerns.
Key Changes:
- Moved LSP client initialization, configuration, and lifecycle management from
extension.tstolinter.ts - Created a new
commands.tsfile to centralize command constants - Simplified
extension.tsto focus on extension-level orchestration by delegating to linter-specific functions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| editors/vscode/client/linter.ts | New file containing all LSP client logic, server initialization, status bar management, and configuration handlers |
| editors/vscode/client/extension.ts | Simplified to orchestrate extension activation by delegating to linter functions |
| editors/vscode/client/commands.ts | New file extracting command constants for better organization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sysix
force-pushed
the
11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_
branch
from
e919504 to
7e3135f
Compare
camc314
approved these changes
Nov 19, 2025
Contributor
Merge activity
|
> This PR refactors the VSCode extension by extracting LSP-related functionality from extension.ts into a new linter.ts module, improving code organization and separation of concerns. > > Key Changes: > > - Moved LSP client initialization, configuration, and lifecycle management from extension.ts to linter.ts > - Created a new commands.ts file to centralize command constants > - Simplified extension.ts to focus on extension-level orchestration by delegating to linter-specific functions
graphite-app
bot
force-pushed
the
11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_
branch
from
7e3135f to
05ca02f
Compare
graphite-app
bot
deleted the
11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_
branch
Copilot AI
pushed a commit
that referenced
this pull request
Nov 21, 2025
> This PR refactors the VSCode extension by extracting LSP-related functionality from extension.ts into a new linter.ts module, improving code organization and separation of concerns. > > Key Changes: > > - Moved LSP client initialization, configuration, and lifecycle management from extension.ts to linter.ts > - Created a new commands.ts file to centralize command constants > - Simplified extension.ts to focus on extension-level orchestration by delegating to linter-specific functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.