refactor(vscode): run js language server with node
#15845
Merged
+23
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 18, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sysix
changed the title
nodenode
github-actions
bot
added
the
C-cleanup
Sysix
commented
Nov 18, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the VSCode extension to automatically detect and run JavaScript-based language servers with node, replacing the previous test-only environment variable approach.
Key changes:
- Replaces
OXLINT_LSP_TESTenvironment variable check with automatic detection of JavaScript files based on extension - Removes security validation that enforces binary filename contains
oxc_language_serveroroxlint - Updates test configuration to remove the now-unnecessary environment variable
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| editors/vscode/client/linter.ts | Implements automatic detection of JavaScript files (.js, .cjs, .mjs) to determine whether to run with node instead of checking environment variable |
| editors/vscode/client/PathValidator.ts | Removes filename validation check that required binary name to contain oxc_language_server or oxlint |
| editors/vscode/tests/PathValidator.spec.ts | Removes test cases for the deleted filename validation logic |
| editors/vscode/.vscode-test.mjs | Removes OXLINT_LSP_TEST environment variable that is no longer used |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camc314
approved these changes
Nov 19, 2025
graphite-app
bot
changed the base branch from
11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_
to
graphite-base/15845
Contributor
Merge activity
|
Sysix
force-pushed
the
11-18-refacor_vscode_run_js_language_server_with_node_
branch
from
784a33c to
266e0b0
Compare
graphite-app
bot
force-pushed
the
11-18-refacor_vscode_run_js_language_server_with_node_
branch
from
266e0b0 to
0146b4c
Compare
graphite-app
bot
deleted the
11-18-refacor_vscode_run_js_language_server_with_node_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.