Skip to content

Conversation

@motin
Copy link
Contributor

@motin motin commented Dec 5, 2015

This helps isolate odd iconv transliteration behavior, to make it clear when Propel2 is at fault and when failed tests stems from incorrect/unsupported locale configuration.

@motin motin force-pushed the additional-iconv-transliteration-tests branch from d8b28fd to 8e0100c Compare December 5, 2015 19:06
@motin motin changed the title Additional iconv transliteration tests for sluggable behavior Additional iconv transliteration tests Dec 5, 2015
@motin motin force-pushed the additional-iconv-transliteration-tests branch from 8e0100c to 2c632b0 Compare December 5, 2015 21:02
@marcj
Copy link
Member

marcj commented Mar 11, 2016

Well, guess this is not complete since there is a PHP error in the tests

@motin motin force-pushed the additional-iconv-transliteration-tests branch from e809a5f to ae41630 Compare June 9, 2016 12:36
@motin
Copy link
Contributor Author

motin commented Jun 9, 2016

@marcj This is now complete with passing tests

@motin motin force-pushed the additional-iconv-transliteration-tests branch from ae41630 to 32ae3c7 Compare September 2, 2016 09:22
@dereuromark
Copy link
Contributor

This looks nice!
Can we maybe rebase against master (or merge it) so we can check if it is still green and merge it?

@Incognito
Copy link
Contributor

Incognito commented Jul 1, 2020

PHP links to libiconv installed on the host, it doesn't ship specific versions (similar to how PHP uses cURL, etc...).

Beware: A lot of this behaviour is dependent on libiconv which has serious changes between 2015 and 2020. I ran into problems in 2016/2017 on PHP 7.x (but the version of php is irrelevant) because the base debian image on the host was built with one old version of libiconv and we were migrating to a new distro release which had a more modern libiconv release.

https://www.gnu.org/software/libiconv/

libiconv changelog: https://git.savannah.gnu.org/gitweb/?p=libiconv.git;a=blob_plain;f=ChangeLog;hb=refs/heads/master

Testing this could be tricky, you can't lock it down with composer afaik.

@PhilinTv
Copy link
Contributor

Add later to doc:
⚠️ Iconv transliteration tests may fail if the system locale is C or if libiconv version is inconsistent. To ensure stability, use en_US.UTF-8 locale when running tests.

@PhilinTv
Copy link
Contributor

Had to refactor a bit, but it finally made it, after years of waiting :)
#2053

@PhilinTv PhilinTv closed this Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants