Skip to content

Conversation

@PhilinTv
Copy link
Contributor

@PhilinTv PhilinTv commented Jun 24, 2025

Based on initial #1057
This helps isolate odd iconv transliteration behavior, to make it clear when Propel2 is at fault and when failed tests stems from incorrect/unsupported locale configuration.

⚠️ Iconv transliteration tests may fail if the system locale is C or if libiconv version is inconsistent. To ensure stability, use en_US.UTF-8 locale when running tests.

@PhilinTv PhilinTv added the Tests label Jun 24, 2025
@PhilinTv PhilinTv force-pushed the additional-iconv-transliteration-tests branch from d42adf0 to 259ab9c Compare June 24, 2025 11:46
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.03%. Comparing base (353266c) to head (47df675).
⚠️ Report is 7 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2053      +/-   ##
============================================
+ Coverage     68.56%   74.03%   +5.46%     
- Complexity     8073     8075       +2     
============================================
  Files           232      232              
  Lines         24569    24575       +6     
============================================
+ Hits          16845    18193    +1348     
+ Misses         7724     6382    -1342     
Flag Coverage Δ
5-max 74.03% <ø> (+5.46%) ⬆️
7.4 74.03% <ø> (+5.46%) ⬆️
agnostic ?
mysql 69.85% <ø> (?)
pgsql 69.90% <ø> (?)
sqlite 67.84% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PhilinTv PhilinTv merged commit 6cb272b into propelorm:master Jun 24, 2025
105 checks passed
@PhilinTv PhilinTv deleted the additional-iconv-transliteration-tests branch June 24, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants