Skip to content

Conversation

@PhilinTv
Copy link
Contributor

  1. We need to include the PHP 8.3 in the standard CI process.
  2. We need to ensure compatibility with the latest PSQL versions (atm the jobs are stopped).

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.70%. Comparing base (1ca6543) to head (7ed71c2).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1995      +/-   ##
============================================
- Coverage     89.28%   87.70%   -1.58%     
  Complexity     8058     8058              
============================================
  Files           232      232              
  Lines         24534    24534              
============================================
- Hits          21905    21518     -387     
- Misses         2629     3016     +387     
Flag Coverage Δ
5-max 87.70% <ø> (-1.58%) ⬇️
7.4 87.70% <ø> (-1.58%) ⬇️
agnostic 67.44% <ø> (ø)
mysql 69.83% <ø> (ø)
pgsql ?
sqlite 67.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PhilinTv PhilinTv changed the title Update ci.yml Update CI with newer PHP and PSQL verions Mar 20, 2024
@PhilinTv PhilinTv changed the title Update CI with newer PHP and PSQL verions Update CI with newer PHP and PSQL versions Mar 20, 2024
@PhilinTv PhilinTv changed the title Update CI with newer PHP and PSQL versions WIP Update CI with newer PHP and PSQL versions Mar 25, 2024
@smhg
Copy link
Contributor

smhg commented Jun 17, 2025

@PhilinTv if you rebase this, only the Pgsql change remains. If still useful, I think it's good to merge?
Although maybe wait for the rebase push to run the testsuite?

Separate v16 from the v9 runs.
@PhilinTv PhilinTv force-pushed the extending-with-php8.3-psql12-16 branch from 7ed71c2 to 7575b64 Compare June 17, 2025 15:49
@smhg
Copy link
Contributor

smhg commented Jun 18, 2025

@PhilinTv if you merge #2052 into this branch, I think this PR is ready to go.
It was trying to run those Postgres tests on PHP 7.4 with Symfony 6.x but this combination is excluded. Symfony 5 is the only version that runs on 7.4.

* fix syntax error in pgsql test setup

* fix php and symfony version match in pgsql install
@PhilinTv PhilinTv merged commit 3883b82 into master Jun 18, 2025
105 checks passed
@PhilinTv PhilinTv deleted the extending-with-php8.3-psql12-16 branch June 18, 2025 14:14
@PhilinTv PhilinTv added the Tests label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants