fix: instantiating TwitterCardTags with image and no fallback image specified #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphjsmit
changed the title
Owner
|
Thanks! Just released in 1.7.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99
Question I have though on this, is it expected that the TwitterCardTag would fallback to the image in the SEO Config? Because I don't see that happening, perhaps it's an oversight? I figured I wouldn't touch that, only fixing the core problem of the secure_url issue.
To be honest I'm not entirely convinced it's this packages fault. It uses the helper secure_url provided by the framework, that function always expects a string to be returned, but it has two different return types?
I don't see this PR having any impact on if they resolve that up the chain either.
Also included a test for this behaviour, if you roll back the change I did to lines 22-23, and run the test, you should get the error. If you implement my fix, it'll work as I presume is expected!
Cheers!