-
Notifications
You must be signed in to change notification settings - Fork 40
Prep for 5.2.0 release #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @tobias, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request prepares for the 5.2.0 release by implementing crucial authentication settings for the Sonatype OSS Index analyzer, making it functional again. It also significantly improves the clarity and maintainability of the project's integration tests and updates several core dependencies to their latest stable versions, ensuring compatibility and leveraging new features. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request prepares for the 5.2.0 release by adding Sonatype OSS Index authentication support, cleaning up integration tests, and updating dependencies. My review focuses on improving the test script readability and fixing inconsistencies in the new OSS Index configuration feature.
I've found a few areas for improvement:
- The integration test script has some redundant commands that can be removed to improve clarity.
- There's a typo in the
README.mddocumentation for the new feature. - There is a significant inconsistency between the implementation of the OSS Index configuration in
src/nvd/config.cljand its documentation inREADME.mdand the default config template. The implementation expects a nested map structure, while the documentation specifies a flat structure. I've provided suggestions to align the implementation with the documentation. This also affects one of the test configuration files.
336e213 to
f93d009
Compare
This allows users to set the ossindex username & password via configuration or environment variables. Co-authored-by: Stefan van den Oord <[email protected]> Co-authored-by: Toby Crawley <[email protected]>
This should make them easier to read, and make it easier to know what step failed.
This version is needed to support OSS Index authentication.
25 is released, and is a supported release, so we'll test with it instead of 24 (a dev release).
f93d009 to
e84cab5
Compare
Pull Request Test Coverage Report for Build 18043030801Details
💛 - Coveralls |
|
Thanks @rm-hull! |
Add settings for Sonatype ossindex authentication
This allows users to set the ossindex username & password via
configuration or environment variables.
Co-authored-by: Stefan van den Oord [email protected]
Co-authored-by: Toby Crawley [email protected]
Clean up integration tests
This should make them easier to read, and make it easier to know what
step failed.
Update to dependency-check-core 12.1.6
This version is needed to support OSS Index authentication.
Update stale dependencies
Update test matrix to use java 25 instead of 24
25 is released, and is a supported release, so we'll test with it
instead of 24 (a dev release).
Prep for 5.2.0 release