Skip to content

Conversation

@tobias
Copy link
Collaborator

@tobias tobias commented Sep 26, 2025

Add settings for Sonatype ossindex authentication

This allows users to set the ossindex username & password via
configuration or environment variables.

Co-authored-by: Stefan van den Oord [email protected]
Co-authored-by: Toby Crawley [email protected]

Clean up integration tests

This should make them easier to read, and make it easier to know what
step failed.

Update to dependency-check-core 12.1.6

This version is needed to support OSS Index authentication.

Update stale dependencies

Update test matrix to use java 25 instead of 24

25 is released, and is a supported release, so we'll test with it
instead of 24 (a dev release).

Prep for 5.2.0 release

@gemini-code-assist
Copy link

Summary of Changes

Hello @tobias, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request prepares for the 5.2.0 release by implementing crucial authentication settings for the Sonatype OSS Index analyzer, making it functional again. It also significantly improves the clarity and maintainability of the project's integration tests and updates several core dependencies to their latest stable versions, ensuring compatibility and leveraging new features.

Highlights

  • Sonatype OSS Index Authentication: Introduced new configuration options (:ossindex-username and :ossindex-password within the :analyzer map) and environment variables (ANALYZER_OSSINDEX_USER, ANALYZER_OSSINDEX_PASSWORD) to enable authentication for the Sonatype OSS Index analyzer, which is now mandatory for its operation.
  • Integration Test Improvements: Refactored the integration test script (.github/integration_test.sh) to enhance readability and provide clearer output for debugging. Each test step now includes a descriptive name, and temporary output files have been standardized.
  • Dependency Updates: Updated several key dependencies, including org.owasp/dependency-check-core to 12.1.6 (necessary for OSS Index authentication), org.clojure/clojure to 1.12.3, com.google.errorprone/error_prone_annotations to 2.42.0, com.google.code.gson/gson to 2.13.2, and clj-kondo to 2025.09.22. commons-logging was also explicitly added and excluded from dependency-check-core to manage transitive dependencies.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares for the 5.2.0 release by adding Sonatype OSS Index authentication support, cleaning up integration tests, and updating dependencies. My review focuses on improving the test script readability and fixing inconsistencies in the new OSS Index configuration feature.

I've found a few areas for improvement:

  • The integration test script has some redundant commands that can be removed to improve clarity.
  • There's a typo in the README.md documentation for the new feature.
  • There is a significant inconsistency between the implementation of the OSS Index configuration in src/nvd/config.clj and its documentation in README.md and the default config template. The implementation expects a nested map structure, while the documentation specifies a flat structure. I've provided suggestions to align the implementation with the documentation. This also affects one of the test configuration files.

@tobias tobias force-pushed the tobias/prep-for-5.2.0-release branch 3 times, most recently from 336e213 to f93d009 Compare September 26, 2025 14:58
Stefan van den Oord and others added 5 commits September 26, 2025 11:00
This allows users to set the ossindex username & password via
configuration or environment variables.

Co-authored-by: Stefan van den Oord <[email protected]>
Co-authored-by: Toby Crawley <[email protected]>
This should make them easier to read, and make it easier to know what
step failed.
This version is needed to support OSS Index authentication.
25 is released, and is a supported release, so we'll test with it
instead of 24 (a dev release).
@tobias tobias force-pushed the tobias/prep-for-5.2.0-release branch from f93d009 to e84cab5 Compare September 26, 2025 15:01
@coveralls
Copy link

coveralls commented Sep 26, 2025

Pull Request Test Coverage Report for Build 18043030801

Details

  • 28 of 30 (93.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 52.038%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nvd/config.clj 28 30 93.33%
Totals Coverage Status
Change from base Build 17909468636: 0.6%
Covered Lines: 166
Relevant Lines: 319

💛 - Coveralls

@tobias
Copy link
Collaborator Author

tobias commented Sep 26, 2025

@vemv @rm-hull Would one of y'all be able to take a look at this so I can release 5.2.0?

@tobias
Copy link
Collaborator Author

tobias commented Sep 26, 2025

Thanks @rm-hull!

@tobias tobias merged commit 21b4a93 into main Sep 26, 2025
8 checks passed
@tobias tobias deleted the tobias/prep-for-5.2.0-release branch September 26, 2025 18:06
@tobias tobias mentioned this pull request Sep 26, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants