Skip to content

Conversation

@djc
Copy link
Contributor

@djc djc commented Dec 2, 2025

This seems to compile at least. I still want to give it another look, but happy to get feedback from others, too.

Let me know if/where it needs more comments.

@djc djc requested review from ChrisDenton and rami3l December 2, 2025 21:09
@djc djc force-pushed the static-roots branch 2 times, most recently from ba961f3 to 6c4d909 Compare December 2, 2025 21:43
@rami3l
Copy link
Member

rami3l commented Dec 3, 2025

@djc Not directly related, but should we establish a standard for generated files and include src/dist/triple/known.rs?

And, since I cannot compile the code (yet) so I'm not able to verify, maybe it's a good idea to disable rustfmt and/or clippy in the generated files in case anything changes in these two tools?

@rami3l rami3l mentioned this pull request Dec 6, 2025
5 tasks
@djc djc force-pushed the static-roots branch 2 times, most recently from 79ec500 to ddc5602 Compare December 8, 2025 11:39
@djc
Copy link
Contributor Author

djc commented Dec 8, 2025

@djc Not directly related, but should we establish a standard for generated files and include src/dist/triple/known.rs?

I think it's fine for now, we should re-evaluate if/when we add something else.

@rami3l
Copy link
Member

rami3l commented Dec 8, 2025

Many thanks :)

@djc djc added this pull request to the merge queue Dec 8, 2025
Merged via the queue into main with commit 1f2c3aa Dec 8, 2025
29 checks passed
@djc djc deleted the static-roots branch December 8, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants