Skip to content

Conversation

@Unheilbar
Copy link
Contributor

@Unheilbar Unheilbar commented Oct 23, 2025

Supported by chainlink-solana

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

⚠️ API Diff Results - Breaking changes detected

📦 Module: github-com-smartcontractkit-chainlink-common

🔴 Breaking Changes (3)

pkg/types.Relayer (1)
  • Solana — ➕ Added
pkg/types/chains/solana.AccountMeta (1)
  • PublicKey — Type changed:
  - [32]byte
  + PublicKey
)
pkg/types/core.Relayer (1)
  • Solana — ➕ Added

📄 View full apidiff report

jmank88
jmank88 previously approved these changes Nov 20, 2025
yashnevatia
yashnevatia previously approved these changes Nov 20, 2025
silaslenihan
silaslenihan previously approved these changes Nov 20, 2025
@pavel-raykov
Copy link
Contributor

Hi, this seems like a massive PR: 11k lines of code where only ~50% (pg.go + mocks) are directly marked as generated. Could you please say how much of this PR is generated using the go tools (including genAI)? I am asking since it seems that there are random code pieces which are unused, e.g., like half of pkg/types/chains/solana/lp_types.go : its const part, type EventIdl EventIDLTypes and its descendants; e.g., most of const entries in pkg/types/chains/solana/solana.go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants