feat(browser): Switch Dapp account #19225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friofry
requested review from
a team,
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
friofry
requested review from
Copilot and
vkjr
and removed request for
a team
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for displaying and managing browser-connected dApps in the Status desktop application. It introduces a new provider for browser dApps that integrates with the existing wallet connector infrastructure, allowing users to view and disconnect browser dApps from the UI.
- Adds
BCBrowserDappsProvidercomponent to track browser-connected dApps - Extends connector infrastructure to support client ID filtering and multi-client scenarios
- Adds UI elements in browser header to display and manage connected dApps
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/imports/shared/popups/walletconnect/controls/DAppDelegate.qml | Adds clickability and connector badge support to dApp delegate items |
| ui/imports/shared/popups/walletconnect/DAppsListPopup.qml | Makes connect button visibility configurable |
| ui/app/AppLayouts/Wallet/services/dapps/qmldir | Registers new BCBrowserDappsProvider component |
| ui/app/AppLayouts/Wallet/services/dapps/DAppsModel.qml | Adds connectorBadge field to dApp model |
| ui/app/AppLayouts/Wallet/services/dapps/BCBrowserDappsProvider.qml | New provider component for browser dApps with client ID filtering |
| ui/app/AppLayouts/Wallet/panels/WalletAccountHeader.qml | Disables dApp clicking in wallet header context |
| ui/app/AppLayouts/Wallet/controls/DappsComboBox.qml | Adds click handler and configurable connect button |
| ui/app/AppLayouts/Browser/provider/qml/ConnectorManager.qml | Removes debug logging and adds clientId to disconnect calls |
| ui/app/AppLayouts/Browser/provider/qml/ConnectorBridge.qml | Adds disconnectCurrentTab helper and updates disconnect signature |
| ui/app/AppLayouts/Browser/panels/BrowserHeader.qml | Adds DappsComboBox to browser header for dApp management |
| ui/app/AppLayouts/Browser/BrowserLayout.qml | Integrates BCBrowserDappsProvider and handles dApp navigation/disconnection |
| src/backend/connector.nim | Updates RPC to support clientId parameter for disconnection |
| src/app_service/service/connector/service.nim | Adds getDAppsByClientId method with filtering logic |
| src/app/modules/shared_modules/connector/controller.nim | Updates disconnect and adds getDAppsByClientId to controller |
| src/app/core/signals/remote_signals/connector.nim | Adds clientId field to all connector signal types |
Comments suppressed due to low confidence (1)
src/backend/connector.nim:43
- Corrected spelling of 'aargs' to 'args' in parameter name.
aargs: RejectedArgs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| _hasPermission = newAccounts.length > 0 | ||
|
|
||
| providerStateChanged() | ||
| accuntsChangedEvent(accounts) |
There was a problem hiding this comment.
Corrected spelling of 'accunts' to 'accounts' in function name.
Suggested change
| accuntsChangedEvent(accounts) | |
| accountsChangedEvent(accounts) |
Comment on lines
81
to
89
| MouseArea { | ||
| Layout.fillWidth: true | ||
| Layout.fillHeight: true | ||
| enabled: root.clickable | ||
| cursorShape: root.clickable ? Qt.PointingHandCursor : Qt.ArrowCursor | ||
| onClicked: { | ||
| root.dappClicked(root.url) | ||
| } | ||
| } |
There was a problem hiding this comment.
MouseArea with Layout.fillWidth and Layout.fillHeight will consume layout space and compete with the ColumnLayout at line 48 which also has Layout.fillWidth: true. This can cause incorrect layout behavior. The MouseArea should likely be positioned as an overlay using anchors instead of being a layout item, or the ColumnLayout should not have fillWidth.
Member
Jenkins BuildsClick to see older builds (43)
|
friofry
force-pushed
the
ab/issue-18545-connector-backend-5
branch
2 times, most recently
from
36c4ce8 to
f6db4b8
Compare
friofry
force-pushed
the
ab/issue-19223-dapps-combobox
branch
2 times, most recently
from
a8025b7 to
6194138
Compare
friofry
force-pushed
the
ab/issue-18545-connector-backend-5
branch
from
b8544f5 to
4903151
Compare
friofry
force-pushed
the
ab/issue-19223-dapps-combobox
branch
from
6194138 to
37aa5d1
Compare
alexjba
approved these changes
Nov 11, 2025
friofry
force-pushed
the
ab/issue-19223-dapps-combobox
branch
from
37aa5d1 to
5fe7b0b
Compare
friofry
changed the base branch from
ab/issue-18545-connector-backend-5
to
master
friofry
force-pushed
the
ab/issue-19223-dapps-combobox
branch
from
5fe7b0b to
7b2d8e7
Compare
This was referenced Nov 11, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dApps list Popup in Browser
Adds a connected dApps popup in the browser header, allowing users to view and manage connected dApps from the browser.
BCBrowserDappsProviderfor browser-specific dApps withclientIdfilteringDappsComboBoxin the browser header for viewing and managing connectionsclientIdthroughout the stackclientIdsupportfixes #19223