[CHERRY-PICK] fix: improve emoji actions and other chat popups #19385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- StatusMessageEmojiReactions: update according to the latest Figma designs, simplify the `showReactionAuthors()` function - StatusMessage: disable the hover quick actions on mobile; the context menu works much better and has the same actions (including the emoji quick reactions) - StatusTextMessage: make it `enabled: false` in order to support the long-press context menu on mobile - MessageView: streamline context menus opening that works with both mouse and touch - WalletAccountHeader: support fallback account icons (non-emojis) - RenameAccountModal: fix changing the emoji of an existing wallet account - removed some unused properties - update and fixed the relevant SB pages - do no use hardcoded margins/paddings - fix some QML warnings Fixes #19328 Fixes #19327 Iterates: #19199
caybro
requested review from
a team,
alexjba,
micieslak and
noeliaSD
as code owners
caybro
requested review from
anastasiyaig and
vkjr
and removed request for
a team
caybro
changed the title
caybro
requested review from
jrainville
and removed request for
anastasiyaig and
vkjr
Member
Jenkins Builds
|
jrainville
approved these changes
Nov 25, 2025
alexjba
approved these changes
Nov 25, 2025
- use StatusTextArea for StatusTextMessage; need this for the context menu on mobile - rework the context menu to ContextMenu + pressAndHold handler (the only combo that works on mobile) - use edge-to-edge separators in the profile context menu
caybro
force-pushed
the
cherry-pick-19362-to-release-2.36.x
branch
from
b1e3b58 to
f473bef
Compare
This was referenced Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #19362
What does the PR do
showReactionAuthors()functionStatusTextAreain order to support the long-press context menu on mobileFixes #19328
Fixes #19327
Iterates: #19199
Affected areas
Messaging, Account edit
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Emoji reactions:
Impact on end user
More consistent emojis behavior, improved esp. on mobile
How to test
Risk