Skip to content

enh: remove tbname scan from stream trigger scan plan. #33641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

enh: remove tbname scan from stream trigger scan plan. #33641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions source/libs/parser/src/parTranslater.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14724,9 +14724,6 @@ static int32_t createStreamReqBuildTriggerSelect(STranslateContext* pCxt, SRealT
if (pPreFilter) {
PAR_ERR_JRET(nodesCollectColumnsFromNode(pPreFilter, NULL, COLLECT_COL_TYPE_TAG, &((SSelectStmt*)*pTriggerSelect)->pProjectionList));
}
PAR_ERR_JRET(createTbnameFunction(&pFunc));
PAR_ERR_JRET(nodesListMakeStrictAppend(&((SSelectStmt*)*pTriggerSelect)->pProjectionList, (SNode*)pFunc));

return code;
_return:
nodesDestroyNode((SNode*)pFunc);
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The variable pFunc is no longer used after the changes. This call to nodesDestroyNode can be removed. It would also be good to remove the declaration of pFunc on line 14715 to avoid compiler warnings about an unused variable.

Expand Down
Loading