Feat/flash-backup-implementation #1409
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| [api] | ||
| version="4.8.0" | ||
| extraOrigins="https://google.com,https://test.com" | ||
| [local] | ||
| sandbox="yes" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,25 @@ | ||||||
| [ | ||||||
| { | ||||||
| "id": "a68667b6-f4ef-4c47-aec3-d9886be78487", | ||||||
| "name": "Test", | ||||||
| "sourceType": "RAW", | ||||||
| "destinationType": "RCLONE", | ||||||
| "schedule": "0 2 * * *", | ||||||
| "enabled": true, | ||||||
| "sourceConfig": { | ||||||
| "label": "Raw file backup", | ||||||
| "sourcePath": "/Users/elibosley/Desktop", | ||||||
|
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion Use generic path for development configuration. The hardcoded user-specific path - "sourcePath": "/Users/elibosley/Desktop",
+ "sourcePath": "/tmp/backup-test",📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| "excludePatterns": [], | ||||||
| "includePatterns": [] | ||||||
| }, | ||||||
| "destinationConfig": { | ||||||
| "type": "RCLONE", | ||||||
| "remoteName": "google_drives", | ||||||
| "destinationPath": "desktop" | ||||||
| }, | ||||||
| "createdAt": "2025-05-27T15:02:31.655Z", | ||||||
| "updatedAt": "2025-05-27T15:11:40.547Z", | ||||||
| "lastRunAt": "2025-05-27T15:07:37.139Z", | ||||||
| "lastRunStatus": "Failed: RClone group backup-job_1748358397105_sbo5j322k failed or timed out." | ||||||
| } | ||||||
| ] | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,12 @@ | ||
| { | ||
| "version": "4.9.5", | ||
|
Contributor
There was a problem hiding this comment. Version inconsistency detected across configuration files. This file shows version 4.9.5 while 🤖 Prompt for AI Agents |
||
| "extraOrigins": [ | ||
| "https://google.com", | ||
| "https://test.com" | ||
| ], | ||
| "sandbox": true, | ||
| "ssoSubIds": [], | ||
| "plugins": [ | ||
| "unraid-api-plugin-connect" | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| [api] | ||
| version="4.8.0" | ||
| extraOrigins="https://google.com,https://test.com" | ||
| [local] | ||
| sandbox="yes" | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Version update looks good, but verify consistency across configs.
The version bump to 4.8.0 aligns with the new backup management features. However, ensure this version is consistent with other configuration files in the codebase.
🏁 Script executed:
Length of output: 380
Unify version fields across all dev configs
The bump to 4.8.0 in
api/dev/Unraid.net/myservers.cfg(andapi/dev/states/myservers.cfg) is correct, but I found these mismatches:The overall API config in
api/dev/configs/api.jsonremains at 4.9.5; please confirm if that should align with the myservers release or stay as-is.Once these are synced, the version will be consistent across the codebase.
🤖 Prompt for AI Agents