Skip to content

fix: add missing is_encoder_decoder arg #4688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hukongyi wants to merge 1 commit into from
+1 −0
Closed

fix: add missing is_encoder_decoder arg #4688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/ut/core/test_schedule_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ def setUp(self):
max_model_len=8192,
is_multimodal_model=False,
send_delta_data=False,
is_encoder_decoder=False,
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This correctly adds the missing is_encoder_decoder argument. However, there is another instantiation of SchedulerConfig in this file that also needs to be updated. On line 90, SchedulerConfig is called without is_encoder_decoder, which will likely cause the test_valid_config_with_multimodal test to fail with a pydantic.ValidationError.

Please update lines 90-91 from:

SchedulerConfig(is_multimodal_model=True,
                max_num_batched_tokens=8192), {})

to:

SchedulerConfig(is_multimodal_model=True,
                max_num_batched_tokens=8192,
                is_encoder_decoder=False), {})

)

def test_initialize_from_config_with_default(self):
Expand Down
Loading