Skip to content

Conversation

@willingc
Copy link
Member

@willingc willingc commented Nov 13, 2025

This PR updates the pre-commit configuration file to use recent library versions. It also corrects deprecated settings. It preserves the string quote style to minimize unneeded code churn. Pre-commit will ignore checking notebook files and .github files to minimize unnecessary changes.

The pyproject.toml file was updated for Python version 3.10 (the lowest supported version for papermill). Deprecated settings have been updated.

The docstring was manually fixed in setup.py to improve on the suggested autofix.

There are no papermill source file changes other than docstring formatting.

Closes #834 Supercedes #840

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.13%. Comparing base (cb2eb37) to head (cfc6a8e).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #843      +/-   ##
==========================================
- Coverage   91.54%   91.13%   -0.42%     
==========================================
  Files          17       17              
  Lines        1621     1635      +14     
==========================================
+ Hits         1484     1490       +6     
- Misses        137      145       +8     
Files with missing lines Coverage Δ
papermill/abs.py 100.00% <ø> (ø)
papermill/adl.py 100.00% <ø> (ø)
papermill/engines.py 95.81% <ø> (-2.57%) ⬇️
papermill/inspection.py 100.00% <100.00%> (ø)
papermill/log.py 100.00% <ø> (ø)
papermill/models.py 100.00% <ø> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb6b602...cfc6a8e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@willingc willingc requested review from Borda and rgbkrk November 14, 2025 00:37
@willingc willingc merged commit 541ee66 into nteract:main Nov 14, 2025
13 checks passed
@willingc willingc deleted the pre-update branch November 14, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chore: update the precommit config

2 participants