Skip to content

Conversation

@hiyuchang
Copy link
Collaborator

Description

As the title says

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hiyuchang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the project's documentation by adding detailed information about the supported reinforcement learning algorithms and recent project news. The updates are applied to both English and Chinese versions of the main README and the Sphinx documentation, providing users with a clearer understanding of the framework's capabilities and latest developments.

Highlights

  • Updated Algorithm Support Documentation: The README.md and its Chinese counterpart, README_zh.md, have been updated to include a new section detailing the comprehensive algorithm support within Trinity-RFT. This section lists popular RL algorithms like PPO, GRPO, GSPO, TOPR, REC, and sPPO, along with examples of modular components for extending new algorithms (e.g., CISPO, SAPO for policy loss; RLOO, REINFORCE for advantage estimation), and hybrid approaches like CHORD and LLM-as-a-judge.
  • New News Entry Added: A new news item for December 2025 has been added to both README.md and README_zh.md, highlighting Trinity-RFT's role in powering 'AI Medicine Finder' for understanding vague symptoms and providing precise recommendations.
  • Sphinx Documentation Synchronization: The Sphinx documentation files, main.md and main_zh.md, have also been updated to reflect the new 'Comprehensive Algorithm Support' section, ensuring consistency across all documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README files (both English and Chinese) and the corresponding Sphinx documentation to include a new section on supported algorithms and a recent news item. The changes are straightforward and well-propagated across all relevant documentation files. I've found a couple of minor issues in the Chinese documentation (README_zh.md and docs/sphinx_doc/source_zh/main.md) related to translation consistency and punctuation, for which I've provided suggestions. The English documentation looks good.

Copy link
Collaborator

@yanxi-chen yanxi-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments. Otherwise lgtm.

@hiyuchang hiyuchang merged commit 80c3b1f into modelscope:main Dec 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants